Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email verification #30491

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Fix email verification #30491

merged 1 commit into from
Jan 7, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 5, 2022

Fix #30374

@Pytal Pytal added this to the Nextcloud 24 milestone Jan 5, 2022
@Pytal Pytal requested a review from a team January 5, 2022 04:12
@Pytal Pytal self-assigned this Jan 5, 2022
@Pytal Pytal requested review from PVince81, skjnldsv and come-nc and removed request for a team January 5, 2022 04:12
@Pytal
Copy link
Member Author

Pytal commented Jan 5, 2022

/backport to stable23

@Pytal
Copy link
Member Author

Pytal commented Jan 5, 2022

/backport to stable22

@Pytal Pytal mentioned this pull request Jan 5, 2022
Closed
@blizzz
Copy link
Member

blizzz commented Jan 5, 2022

can we have a unit test for this?

@Pytal Pytal force-pushed the fix/30374/email-verification branch 6 times, most recently from a9c26ae to da95465 Compare January 5, 2022 23:57
@Pytal Pytal force-pushed the fix/30374/email-verification branch 2 times, most recently from 4b425b3 to 0fdba2c Compare January 6, 2022 20:03
@Pytal
Fix email verification
19a3656 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/30374/email-verification branch from 0fdba2c to 19a3656 Compare January 6, 2022 23:47
@Pytal
Copy link
Member Author

Pytal commented Jan 7, 2022

Test updated and passing, would appreciate a re-review or another review now with the updated test :)

@blizzz blizzz merged commit e65431d into master Jan 7, 2022
@blizzz blizzz deleted the fix/30374/email-verification branch January 7, 2022 10:46
This was referenced Jan 7, 2022
Merged
Merged
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: emails feature: users and groups
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

VerifyUserData job always gets readded
4 participants
@Pytal @blizzz @skjnldsv @come-nc